This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Sync: Fix issue of not freeing a block announcement slot#8006
Merged
5 commits merged intomasterfrom Jan 29, 2021
Merged
Conversation
There was a bug that when the block announcement validation returned an error, the slot reserved for this validation wasn't freed. This could lead to a situation where we rejected any block announcement from such a peer for that the block announcement returned an error multiple times.
bkchr
added
A0-please_review
arkpar
approved these changes
Jan 29, 2021
Member
Author
|
Because of me being to dumb to use |
andresilva
approved these changes
Jan 29, 2021
Contributor
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: |
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit
s3krit
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Sync: Fix issue of not freeing a block announcement slot There was a bug that when the block announcement validation returned an error, the slot reserved for this validation wasn't freed. This could lead to a situation where we rejected any block announcement from such a peer for that the block announcement returned an error multiple times. * Better logging * Fuck I'm dumb * 🤦
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug that when the block announcement validation returned an
error, the slot reserved for this validation wasn't freed. This could
lead to a situation where we rejected any block announcement from such a
peer for that the block announcement returned an error multiple times.